rcreate: remove legacy crypto for new repos, fixes #6490 #6821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasWaldmann
force-pushed
the
remove-legacy-repo-creation-borg2
branch
from
536c44f to
eff91ee
Compare
Codecov Report
@@ Coverage Diff @@
## borg2 #6821 +/- ##
==========================================
+ Coverage 81.85% 82.01% +0.15%
==========================================
Files 39 39
Lines 10647 10646 -1
Branches 2084 2218 +134
==========================================
+ Hits 8715 8731 +16
+ Misses 1416 1405 -11
+ Partials 516 510 -6
Continue to review full report at Codecov.
|
ThomasWaldmann
changed the title
…up#6490 These are legacy crypto modes based on AES-CTR mode: (repokey|keyfile)[-blake2] New crypto modes with session keys and AEAD ciphers: (repokey|keyfile)[-blake2]-(aes-ocb|chacha20-poly1305) Tests needed some changes: - most used repokey/keyfile, changed to new modes - some nonce tests removed, the new crypto code does not generate the repo side nonces any more (were only used for AES-CTR)
this way, we can remove the legacy pbkdf2 key code in next release.
ThomasWaldmann
force-pushed
the
remove-legacy-repo-creation-borg2
branch
from
cb65b32 to
eabad3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are legacy crypto modes based on AES-CTR mode:
(repokey|keyfile)[-blake2]
New crypto modes with session keys and AEAD ciphers:
(repokey|keyfile)[-blake2]-(aes-ocb|chacha20-poly1305)
Tests needed some changes:
the repo side nonces any more (were only used for AES-CTR)
For the kdf, only support argon2, so we can remove the legacy code used for pbkdf2 keys in N+1 release.